Skip to content

[enhancement](tcmalloc) add aggressive_memory_decommit conf and make …#12436

Merged
yiguolei merged 1 commit into
apache:masterfrom
yixiutt:tcmalloc_v1
Sep 8, 2022
Merged

[enhancement](tcmalloc) add aggressive_memory_decommit conf and make …#12436
yiguolei merged 1 commit into
apache:masterfrom
yixiutt:tcmalloc_v1

Conversation

@yixiutt

@yixiutt yixiutt commented Sep 7, 2022

Copy link
Copy Markdown
Contributor

…it disable

Proposed changes

Issue Number: close #xxx

Problem summary

Describe your changes.

Checklist(Required)

  1. Does it affect the original behavior:
    • Yes
    • No
    • I don't know
  2. Has unit tests been added:
    • Yes
    • No
    • No Need
  3. Has document been added or modified:
    • Yes
    • No
    • No Need
  4. Does it need to update dependencies:
    • Yes
    • No
  5. Are there any changes that cannot be rolled back:
    • Yes (If Yes, please explain WHY)
    • No

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@xinyiZzz xinyiZzz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xinyiZzz

xinyiZzz commented Sep 7, 2022

Copy link
Copy Markdown
Contributor

a little experience:
This modification will double the performance of some cases, but will cause the BE process to use more memory.
Expect better manual gc strategies in the future to avoid excessive memory usage.

@github-actions

github-actions Bot commented Sep 7, 2022

Copy link
Copy Markdown
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions Bot added the approved Indicates a PR has been approved by one committer. label Sep 7, 2022
@github-actions

github-actions Bot commented Sep 7, 2022

Copy link
Copy Markdown
Contributor

PR approved by anyone and no changes requested.

@yiguolei yiguolei left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/merge-1.1.2 reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants